Focus On Details

I'll use this topic to list -small- bugs & issues that i found in CS Codes. They are usually small details so you can ignore them but CS team can use them for perfectection.

Out Of Localization:

Skin-CreateQuickReply.ascx

<asp:button id="SavePost" Runat="server" Text = "Post" /> <asp:CheckBox Runat = "server" ID = "RefreshPage" Text = "Refresh Page" Checked="True" />

CreateQuickReply.cs

Head.AddTitle(Formatter.RemoveHtml("Reply: " + postReplyingTo.Subject,60),Context);

ForumDropDownList.cs

Items.Insert(0, new ListItem( "All Forums", "f--1"));

Skin-PictureDetails.ascx

...toggleLayers('ViewSizes');" title="View Image Sizes" class="viewsizes">View Sizes</a>

...toggleLayers('ViewExif');" title="View Exif Info" class="viewexif">View Details</a>

Skin-PictureDetails-Exif.ascx

...toggleLayers('ViewSizes');" title="View Image Sizes" class="viewsizes">View Sizes</a>

Skin-EntryComments.ascx

<h3>Comments</h3>

<td colspan="2" class="Comment CommentContent">No comments</td>

WhoIsOnlineView.cs

UsersOnline.SetLocation("Who Is Online");

View-PrivateMessages.ascx

<asp:Button runat="server" text="Delete Checked" id="BulkDeleteButton" />

<asp:Button runat="server" text="Delete Checked" id="BulkDeleteButton" /> 

PollRenderingModule.cs

 

ui.Append("</ul><input name=\"PollVoteCommand\" type=\"submit\" value=\"Vote\" /></div>");

 

View-Gallery.ascx

 

<h3 class="ContentHeader">Photos</h3>

 

Design:

Rating thing is not static in some situations, not sure when but i see it like that so much:

I'm updating "Out Of Localization" section frequently. These are not all. I think it's some much to use CS in local languages, without SDK.

\Themes\Blogs\default\Skins\Skin-AboutAuthor.ascx

 

<h2 class="CommonSubTitle"> <asp:Literal id="UserName" runat="server" /> About</h2>

 

\Themes\Blogs\Photos\Skins\Skin-AboutAuthor.ascx

 

<h2>About <asp:Literal id="UserName" runat="server" /></h2>

 

\source\Galleries\Components\Gallery.cs

 

get{return GetString("aboutTitle", "About " + this.Name);}

 

\source\Blogs\Components\WebLog.cs

 

get{return GetString("aboutTitle", "About " + this.Name);}

 

\source\Galleries\Controls\Aggregate\AggregatePortalPictureListing.cs

 

UsersOnline.SetLocation("Photo Galleries");

 

\source\Web\Themes\Blogs\default\Skins\Skin-RecentPosts.ascx

 

<h4 class="CommonSidebarHeader">Recent Posts</h4>

 

\source\Controls\User\EditProfile.cs

 

UsersOnline.SetLocation("Editing Profile",null);

 

\source\Galleries\Controls\Aggregate\AggregateGalleryListing.cs

 

Head.AddSiteNameTitle("Photo Galleries",Context);

UsersOnline.SetLocation("Photo Galleries");

 

\source\Blogs\Controls\AggregateBlogControls\AggregatePostList.cs

 

Head.AddSiteNameTitle("Blogs", Context);

UsersOnline.SetLocation("Viewing Blogs", cntx.RawUrl);

Please note there is also a thread in the translators forum about missing localization entries.

Nice job anyway. 

Thank you, i didn't noticed that topic. In fact this topic was not about only localization but seems to be so. =) When my job finishes, we can put these under that topic also.